Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show planetscale serverless warning if not installing driver #1777

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

limegorilla
Copy link
Contributor

@limegorilla limegorilla commented Feb 22, 2024

Closes #1776

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Updates ./cli/src/helpers/logNextSteps.ts to only show planetscale error if using the mySQL driver


Screenshots

Before:
image
After:
image

If you are using mySQL you get:
image

💯

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: e1436b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 9:33pm

Copy link

vercel bot commented Feb 22, 2024

@limegorilla is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

limegorilla and others added 2 commits February 23, 2024 21:32
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@juliusmarminge juliusmarminge added this pull request to the merge queue Feb 25, 2024
Merged via the queue into t3-oss:main with commit 640a0e0 Feb 25, 2024
266 of 267 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
…er (t3-oss#1777)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Warning for planetscale's driver is shown regardless of db provider
2 participants