-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: made themeToggleButton a toggle button #799
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-muradbuyukasik-next-t3-oss.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great on my end
* docs: made themeToggleButton a toggle button * fix: more clear function name Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Closes #781
✅ Checklist
Changelog
Refactored themeToggleButton to use a
<button>
root element instead of 2 radio buttons so that the light/dark theme gets toggled regardless of where the user presses within the component.The component's
title
,value
andaria-label
attributes gets set on page-load using the appropriate dark/light state.Screenshots
💯