fix: handle empty env object type #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -91,8 +91,8 @@ export interface StrictOptions< | |||
|
|
|||
| export function createEnv< | |||
| TPrefix extends string, | |||
| TServer extends Record<string, ZodType>, | |||
| TClient extends Record<string, ZodType> | |||
| TServer extends Record<string, ZodType> = NonNullable<unknown>, | |||
There was a problem hiding this comment.
This is my first time using NonNullable<unknown>, an alternative to {}, as the ESLint rule doesn't allow me to use it🤷
There was a problem hiding this comment.
Record<string, never> is the type for {} that eslint allows fyi
There was a problem hiding this comment.
Yeah, I was using that originally, but unfortunately it didn't work in this case.
juliusmarminge
force-pushed
the
main
branch
2 times, most recently
from
2df8c5b
to
7e192c7
Compare
|
whopps - looks like i broke it and i can't seem to push to your branch to fix it back up :/ |
No worries, I will fix it once I'm available to do so. |
|
@juliusmarminge I'm a bit lost here, is it something wrong with the test on CI? It looks like it was trying to typecheck against |
|
Try pushing that to the tsconfig exclude maybe? |
Yeah, seems to work. Just weird that it didn't happen to my local environment. Thx for the help! |
|
Oh we need a changeset too |
Done. |
|
Same type error happening again, probably something wrong with the CI. |
Yea might be a bad turbo config so it's pulling a bad cache or something... i'll take a look! let's get this released :) |
fix #17
Before:
After: