refactor: remove dependency on z.object #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@decs is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
Summary: Test Plan:
|
Thanks for the PR, but I'm a bit confused. How is this better than what we have and how does it progress towards the linked issue? The goal is to have the user pass in a ZodObject instead of a record. Maybe I am missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: remove dependency on z.object
Summary:
A step towards addressing #6. This PR removes the
z.objectinternal wrapper. There's a breaking change on theonValidationErrorfunction, but it should be minor.Test Plan: