fix: identify Deno as server (#154) #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@michaellopez is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
juliusmarminge
approved these changes
Apr 16, 2024
|
Can you fix lint? bun lint:fix |
michaellopez
force-pushed
the
fix/issue-154
branch
from
46f3363
to
907b54b
Compare
@juliusmarminge Lint is fixed, sorry I missed that. |
juliusmarminge
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliusmarminge We hit the faulty server detection explained in #154 when using t3-env on Netlify in a middleware in Next.js. Netlify uses Deno to bundle for edge, and this resulted in builds failing with "❌ Attempted to access a server-side environment variable on the client".
I think Netlify + Next.js middleware + t3-env qualifies as "common setups widely used" as you put it in your comment
We would appreciate out of the box support for this combo.