Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Immersive Jump Label Style and Word Jump #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhaocai
Copy link

@zhaocai zhaocai commented Sep 18, 2016

Immersive Jump Label Style

As discussed in issue #5, word-based jump generates too many labels. The result is interruptive due to the sudden emerging of numerous colorful labels. This pull request tunes the style to be relatively more immersive as demonstrated below.

smalls:start

atom-smalls-immersive

Word Jump Implementation and Issues

smalls:word-jump

atom-smalls-word-jump

word-jump-issues

As shown in the above screenshot, two issues need to be dealt with.

  1. The search highlight should be removed when jump starts.
  2. The labels overlay on top of the search box.

In addition, the code to implement word jump is not optimal; it is likely need to be refined.

Start word boundary jump ( ignore input stage )

z-index : 1;
color : @smalls-label-color;
margin-top: -1.5rem;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To perfectly overlay labels on text, the value of margin-top: -1.5rem; needs to be slightly tuned for different font and font-size. Do you have any better idea to do this?

@t9md
Copy link
Owner

t9md commented Mar 10, 2017

@zhaocai Are you still Atom and smalls user? Are you interested in take ownership of this smalls project?

I've deprecated and thinking to un-publish from atom package registrory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants