Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with latest graphene-django v3.1.2, due to import of compat.JSONField #109

Closed
sjdemartini opened this issue Jun 20, 2023 · 0 comments · Fixed by #110
Closed

Incompatibility with latest graphene-django v3.1.2, due to import of compat.JSONField #109

sjdemartini opened this issue Jun 20, 2023 · 0 comments · Fixed by #110

Comments

@sjdemartini
Copy link
Contributor

sjdemartini commented Jun 20, 2023 •
edited

As of graphene-django 3.1.2, the graphene_django.compat.JSONField model type is no longer defined: graphql-python/graphene-django#1421, since JSONField is built into Django 3.2+

To fix, it should theoretically be as simple as removing the JSONField import here

graphene-django-cud/graphene_django_cud/converter.py

Line 33 in 4a1a743

from graphene_django.compat import ArrayField, HStoreField, JSONField, RangeField

and replacing use of JSONField with models.JSONField.

I see that graphene-django-cud lists its Django dependency as 2.2+, but for what it's worth, 2.2 reached EOL April 2022, so need not be supported anymore. Django 3.2 is the oldest currently-maintained Django version (https://endoflife.date/django).

Happy to submit a PR for this! PR here: #110
sjdemartini added a commit to sjdemartini/graphene-django-cud that referenced this issue Jun 20, 2023
@sjdemartini
Use Django's official JSONField, fixing invalid graphene_django import
ffeee88 
Fixes tOgg1#109
@sjdemartini sjdemartini mentioned this issue Jun 20, 2023
Merged
@tOgg1 tOgg1 closed this as completed in #110 Jul 1, 2023
@sjdemartini sjdemartini mentioned this issue Jul 2, 2023
Merged
sjdemartini added a commit to graphql-python/graphene-django that referenced this issue Jul 8, 2023
@sjdemartini
Maintain JSONField in graphene_django.compat module
7fcb333 
Fixes #1428

This should improve backwards compatibility, fixing issues in downstream
packages (notably graphene-django-cud
tOgg1/graphene-django-cud#109, and also
graphene-django-extras, both of which depended on
`graphene_django.compat.JSONField`).
@sjdemartini sjdemartini mentioned this issue Jul 8, 2023
Merged
firaskafri pushed a commit to graphql-python/graphene-django that referenced this issue Jul 18, 2023
@sjdemartini
Maintain JSONField in graphene_django.compat module (#1429)
cd43022 
Fixes #1428

This should improve backwards compatibility, fixing issues in downstream
packages (notably graphene-django-cud
tOgg1/graphene-django-cud#109, and also
graphene-django-extras, both of which depended on
`graphene_django.compat.JSONField`).

Co-authored-by: Steven DeMartini <sjdemartini@users.noreply.github.com>
superlevure pushed a commit to loft-orbital/graphene-django that referenced this issue Jul 19, 2023
@sjdemartini @superlevure
Maintain JSONField in graphene_django.compat module (graphql-python#1429
4611ab9 
)

Fixes graphql-python#1428

This should improve backwards compatibility, fixing issues in downstream
packages (notably graphene-django-cud
tOgg1/graphene-django-cud#109, and also
graphene-django-extras, both of which depended on
`graphene_django.compat.JSONField`).

Co-authored-by: Steven DeMartini <sjdemartini@users.noreply.github.com>
DevStar1016 added a commit to DevStar1016/graphine-django that referenced this issue Sep 11, 2023
@DevStar1016 @sjdemartini
Maintain JSONField in graphene_django.compat module (#1429)
79133ec 
Fixes graphql-python/graphene-django#1428

This should improve backwards compatibility, fixing issues in downstream
packages (notably graphene-django-cud
tOgg1/graphene-django-cud#109, and also
graphene-django-extras, both of which depended on
`graphene_django.compat.JSONField`).

Co-authored-by: Steven DeMartini <sjdemartini@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix graphene-django 3.1.2 compatibility sjdemartini/graphene-django-cud
1 participant
@sjdemartini