Fix connection check and re-enabled i386 and armv6l support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Re-enabled i386 and armv6l support by searching the latest major version that was compiled for those architecture: v11.x for armv6l and v9.x for i386 + Use curl "-f" option to prevent it from storing 40x error pages in variable but exiting with error code instead: https://linux.die.net/man/1/curl + Force HTTPS connection to nodejs.org + Coding consistency: Redirect all error messages to STDOUT; Use single quotes around arguments with no variable calls, else double quotes; Use double braces for all bash conditionals; Do not assign a variable to another via echo + command substitution overhead; Use consistent if-then-else format Signed-off-by: MichaIng <micha@dietpi.com>
This was referenced Mar 22, 2020
|
@taaem Any interest in further maintaining this script? Otherwise I'll start using and promoting my fork. |
MichaIng
changed the title
MichaIng
added a commit
to MichaIng/DietPi
that referenced
this pull request
Jul 5, 2020
+ DietPi-Software | Node.js: Use fixed own installer fork for now: taaem/nodejs-linux-installer#11
2 tasks
MichaIng
added a commit
to MichaIng/DietPi
that referenced
this pull request
Jul 5, 2020
+ DietPi-Software | Node.js: Use fixed own installer fork for now: taaem/nodejs-linux-installer#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Signed-off-by: MichaIng micha@dietpi.com