Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Warn localization not working if menu is disabled #606

Closed
manzarek123 opened this issue Mar 25, 2022 · 4 comments
Closed

[BUG] Warn localization not working if menu is disabled #606

manzarek123 opened this issue Mar 25, 2022 · 4 comments
Labels
bug Something isn't working confirmed A bug or issue reproducible and confirmed menu

Comments

@manzarek123
Copy link

txAdmin/FXServer versions:
4.13.3/5429

Describe the bug
Localization is not working for Warns when menu is disabled in TxAdmin config

To Reproduce
Steps to reproduce the behavior:

  1. Set Langage to French in Settings->Global
  2. Enable the Menu in Settings->Menu
  3. Restart Server
  4. Warn a player => NUI Warn menu is in French
  5. Disable the Menu in Settings->Menu
  6. Restart Server
  7. Warn a player => NUI Warn menu is in English

Expected behavior
Warns to be in the correct langage with Menu Disabled

@tabarra tabarra added the bug Something isn't working label Mar 26, 2022
@tabarra
Copy link
Owner

tabarra commented Mar 26, 2022

Confirmed.
Related to #608.

@tabarra tabarra added the menu label Mar 26, 2022
@TasoOneAsia
Copy link
Collaborator

TasoOneAsia commented May 20, 2022

The bug can most likely be attributed to improper ServerCtx event listener logic for clients when the menu is disabled. During local testing with the menu disabled, clients never receive the "setServerCtx" event upon update of web settings. ServerCtx is updated within GlobalState but the event is never properly dispatched to clients, as we never populate the TX_ADMINS table when the menu is disabled.

Here is where its blowing up

In fact, after glancing over some of the code, does localization even work in NUI for servers that don't enable OneSync?

@tabarra
Copy link
Owner

tabarra commented Nov 21, 2022

Confirmed that this is still a thing in v5, even though #608 was fixed some time ago :(

@TasoOneAsia TasoOneAsia added the confirmed A bug or issue reproducible and confirmed label Nov 27, 2022
@tabarra
Copy link
Owner

tabarra commented Feb 25, 2024

Issue finally fixed.
Will be available on the next update.

@tabarra tabarra closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed A bug or issue reproducible and confirmed menu
Projects
None yet
Development

No branches or pull requests

3 participants