Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddMasterCallback.tsx #915

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Update AddMasterCallback.tsx #915

merged 1 commit into from
Feb 23, 2024

Conversation

regiments
Copy link
Contributor

correcting the english on the registration page

same as before, correcting the english
@tabarra
Copy link
Owner

tabarra commented Feb 21, 2024

I thought about using the proper word for it, but I think digits will be more understandable.
I'm not confident on my decision though.

@regiments
Copy link
Contributor Author

I thought about using the proper word for it, but I think digits will be more understandable. I'm not confident on my decision though.

Honestly it just confused me a little bit. Characters is a global word, some people will think they can only put numbered combinations which is not only a security risk, its not what the functionality actually is

@tabarra tabarra changed the base branch from master to develop February 23, 2024 05:21
@tabarra tabarra merged commit da2e673 into tabarra:develop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants