Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cl_base.lua #946

Merged
merged 3 commits into from
May 7, 2024
Merged

Update cl_base.lua #946

merged 3 commits into from
May 7, 2024

Conversation

Flowrider
Copy link
Contributor

Fixed Error Message RegisterKeyMapping for RedM

RegisterKeyMapping Error TxAdmin

Fixed Error Message RegisterKeyMapping for RedM
@Flowrider Flowrider requested a review from tabarra as a code owner April 21, 2024 15:41
@tabarra
Copy link
Owner

tabarra commented Apr 25, 2024

This is a weird issue, never happened before.
I think this native used to be a no-op in previous client versions.
Do you know if this bug prevents the tx menu from working in game?

@Flowrider
Copy link
Contributor Author

The menu works perfectly in Game. You only see the error when connecting, which triggers my Monk :D

Actually, it's only an optical bug, at least so far, but it was easy and quick to disable with my change and shouldn't cause any problems.

I don't know from which version this error occurs, I'm currently on Canary, but probably also in beta. I have not tested the release.

@outsider31000
Copy link

This is a weird issue, never happened before. I think this native used to be a no-op in previous client versions. Do you know if this bug prevents the tx menu from working in game?

I made a pr to fix this some weeks ago as well

@outsider31000
Copy link

outsider31000 commented Apr 25, 2024

#928 specific here with other stuff in the pr too

that native is not available in RedM hence why it errors.

@tabarra
Copy link
Owner

tabarra commented May 5, 2024

Just to add context, this actually breaks the menu a little bit.
User report I got:

when I give permissions to any one all admin have to relog in to have access to noclip/ tp. baiscily all the features except the TXAdmin tab

Since it fails on the key mapping command, it never reaches the setPermissions.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants