fix(tablekit-phone-input): remove RTL #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wahidfarid
added
bug
SimeonC
previously approved these changes
Mar 8, 2023
wahidfarid
force-pushed
the
phone-input-remove-rtl
branch
7 times, most recently
from
4f6db95
to
163aa84
Compare
daniellizik
previously approved these changes
Mar 9, 2023
wahidfarid
force-pushed
the
phone-input-remove-rtl
branch
from
163aa84
to
aa7d46a
Compare
daniellizik
previously approved these changes
Mar 9, 2023
Numbers in arabic are read/written left to right. so we need to keep the orientation of the phone input as is, even when used in an RTL environment No issue
wahidfarid
force-pushed
the
phone-input-remove-rtl
branch
from
aa7d46a
to
9a3b381
Compare
daniellizik
approved these changes
Mar 9, 2023
SimeonC
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers in arabic are read/written left to right. so we need to keep the orientation of the phone input as is, even when used in an RTL environment
No issue
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/tablekit-phone-input@3.1.4-canary.167.4370932779.0 # or yarn add @tablecheck/tablekit-phone-input@3.1.4-canary.167.4370932779.0