-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(network): change base uri, removing tables endpoint #456
Conversation
Since this PR makes a tweak to |
Also, @brunocalza—do we really need the edit: I suppose we do need it because we use that type def in the hardhat config, which we obv need in order to deploy to the staging network. |
@joewagner I came across the If you think it's worthwhile, I can try it out on this repo since the publishing action is broken, anyways. It's also supposed to be nice for monorepos, but I'm not sure if we need that with our lerna setup for the SDK/CLI/LT. |
yeah, I guess you're right, we need it for deploying the contract |
I'm not sure, but I think we tried changesets in the past and didn't end up going with it. @carsonfarmer would remember better than me. |
@@ -43,26 +43,25 @@ export const proxies: TablelandNetworkConfig = { | |||
"local-tableland": "0xe7f1725e7734ce288f8367e1bb143e90bb3f0512", | |||
}; | |||
|
|||
const homesteadURI = "https://tableland.network/api/v1/tables/1/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chain Ids are used in the ERC721a tokenURI
method. It simply appends the token / table Id to the baseUri. Wouldn't this change break that functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanderpick ah, i see. the use case i was considering this for was to be able to set the baseURI via a hardhat script that only uses evm-tableland, so it'd be nice to be able to import the baseURIs from network.ts
. but, i think the TablelandDeployments baseURIs can help there, and instead, the SDK getBaseUrl
can provide the correct URL info. i'll just close this out.
and @joewagner sgtm, will tal in the future with #414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all you need is the host name, you could still use these URLs... just pull the host out. /api/v1
will be the same for them all.
Summary
The
baseURIs
include thetables/{chainId}
endpoint, which shouldn't really be used. Instead, it should just be the true/api/v1
endpoint, attached to the correct gateway.Details
See
network.ts
andbaseURIs
.How it was tested
N/A
Checklist: