Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat webhooks #592

Closed
wants to merge 3 commits into from
Closed

Reformat webhooks #592

wants to merge 3 commits into from

Conversation

avichalp
Copy link
Collaborator

@avichalp avichalp commented Jul 11, 2023

Summary

Adds more context to webhooks content by adding hyperlinks for transactions, table ids and chain ids. Fixes GOT-108

Implementation overview

To add links to the tableland docs, and block explorers I have stored these links in the webhooks package against their corresponding chain ids.

  • Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
  • Are changes covered by existing tests, or were new tests included?
  • Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
  • Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
@linear
Copy link

linear bot commented Jul 11, 2023

GOT-108 Add webhook handling to event processo

The hook could be defined in the chain config. Just fire at it in a go routine or similar.

Signed-off-by: avichalp <hi@avichalp.me>
@avichalp avichalp deleted the branch staging July 12, 2023 13:55
@avichalp avichalp closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant