Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open specific tab from hyperlink #768

Merged
merged 4 commits into from
May 3, 2021
Merged

Conversation

kilab
Copy link
Contributor

@kilab kilab commented Jan 5, 2021

Hello,

This is my proposition to small feature in tabs. Sometimes we have to open a tab based on the url (hash). These changes will allow the tab to be opened automatically when page is loaded.

Real life example:

image

src/js/tab.js Outdated Show resolved Hide resolved
Copy link
Contributor

@FreexD FreexD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments :) Thanks for your great work!

src/js/tab.js Outdated Show resolved Hide resolved
src/js/tab.js Outdated Show resolved Hide resolved
Copy link
Contributor

@FreexD FreexD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@FreexD FreexD merged commit 327bab2 into tabler:dev May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants