Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: no more line_color_filter #21

Open
jeremybmerrill opened this issue Apr 29, 2015 · 2 comments
Open

regression: no more line_color_filter #21

jeremybmerrill opened this issue Apr 29, 2015 · 2 comments

Comments

@jeremybmerrill
Copy link
Member

it comes up every now and again that tabula-extractor allowed users (in the Ruby version only -- I don't think there were hooks into the CLI version) to only use lines whose RGB matches a certain lambda for Spreadsheet/Lattice mode.

This doesn't exist in tabula-java

@jazzido
Copy link
Contributor

jazzido commented May 2, 2015

Filtering lines by color is currently implemented in tabula-extractor as a Proc that's passed to the ObjectExtractor. That is, filtering is done at page mining time.

Maybe we could mine every Ruling instead, and provide some kind of option to the Extractors that let the user pass a lambda (that accepts a Ruling as its argument) to allow for more generic filtering.

What do you think?

@jeremybmerrill
Copy link
Member Author

Yes, great. 💯

Jeremy B. Merrill
Sent from my mobile device
On May 2, 2015 6:32 PM, "Manuel Aristarán" notifications@github.com wrote:

Filtering lines by color is currently implemented in tabula-extractor as
a Proc that's passed to the ObjectExtractor. That is, filtering is done
at page mining time.

Maybe we could mine every Ruling instead, and provide some kind of option
to the Extractors that let the user pass a lambda (that accepts a Ruling
as its argument) to allow for more generic filtering.

What do you think?


Reply to this email directly or view it on GitHub
#21 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants