Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicit init function if not present #167

Merged
merged 6 commits into from
Mar 21, 2024
Merged

implicit init function if not present #167

merged 6 commits into from
Mar 21, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Mar 5, 2024

closes #8

anton-trunov
anton-trunov reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Let's add a test that checks what happens when there are some initialized and uninitialized storage vars and the init method is missing

@anton-trunov anton-trunov added this to the v1.3.0 milestone Mar 13, 2024
anton-trunov
anton-trunov requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test mentioned here: #167 (review)

@anton-trunov anton-trunov self-assigned this Mar 15, 2024
anton-trunov
anton-trunov approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@anton-trunov anton-trunov merged commit 7c8fd86 into tact-lang:main Mar 21, 2024
3 checks passed
@novusnota novusnota mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
language feature
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Implicit init function if one does not exist
2 participants
@Gusarich @anton-trunov