Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quotes to all identifiers in error messages for consistency #363

Merged
merged 4 commits into from
May 27, 2024
Merged

Add quotes to all identifiers in error messages for consistency #363

merged 4 commits into from
May 27, 2024

Conversation

Gusarich
Copy link
Member

Closes #361

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone May 26, 2024
anton-trunov
anton-trunov requested changes May 27, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

src/types/resolveStatements.ts Outdated Show resolved Hide resolved
Gusarich and others added 4 commits May 27, 2024 14:17
@anton-trunov anton-trunov merged commit b2dcaf5 into tact-lang:main May 27, 2024
3 checks passed
@zusmanzus zusmanzus mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Identifiers should be quoted in error messages
2 participants
@Gusarich @anton-trunov