-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): Separate Feature Enabling Function #647
chore(build): Separate Feature Enabling Function #647
Conversation
a1171e2
to
65ee86c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one suggestion though, let's start defining(centralizing) our API in index.ts
(see, for instance, https://github.com/ton-org/ton-core/blob/main/src/index.ts). Maybe we can export enableFeatures
and build
in index.ts
to start with. If we do it and add index.ts
to Knip's entry points, then we won't have to ignore build.ts
(which is the right thing to do).
Closes #646
I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBERI have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases