Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Separate Feature Enabling Function #647

Merged
merged 11 commits into from
Aug 2, 2024

Conversation

byakuren-hijiri
Copy link
Contributor

@byakuren-hijiri byakuren-hijiri commented Aug 1, 2024

Closes #646

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@byakuren-hijiri byakuren-hijiri marked this pull request as ready for review August 1, 2024 08:30
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one suggestion though, let's start defining(centralizing) our API in index.ts (see, for instance, https://github.com/ton-org/ton-core/blob/main/src/index.ts). Maybe we can export enableFeatures and build in index.ts to start with. If we do it and add index.ts to Knip's entry points, then we won't have to ignore build.ts (which is the right thing to do).

@anton-trunov anton-trunov self-assigned this Aug 1, 2024
@anton-trunov anton-trunov added this to the v1.4.2 milestone Aug 1, 2024
@anton-trunov anton-trunov merged commit 9c61afe into tact-lang:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor build to Separate Feature Enabling Function
2 participants