Update testing section of README with current info #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soey
reviewed
May 15, 2024
|
|
||
| ```bash | ||
| $ docker compose exec -it app bash | ||
| $ RAILS_ENV=test rspec | ||
| $ docker compose exec app bundle exec rspec |
There was a problem hiding this comment.
I still have to set the env variable RAILS_ENV to test to make the test run. So I think we should replace this line with:
$ docker compose exec -e RAILS_ENV=test app bundle exec rspec
|
Thank you for that @mattwr18 - i think we need to make a small adjustment. Besides that it seems good to go.. |
|
I think we don't need to extend the scope of this MR. We are always free to add more in other MRs if we want to. |
mattwr18
force-pushed
the
update_testing_section_of_readme
branch
from
fc86e34
to
37fc53e
Compare
mattwr18
force-pushed
the
update_testing_section_of_readme
branch
from
37fc53e
to
d70cad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats included in this PR and why
This updates the testing section of the README to remove some outdated info/duplication and to add the info that the tests run from a dedicated test
.env.test.localfile.Whats not included and why
It does not update any other info in the README that would help new collaborators get set up or update outdated info.
This is open for discussion. Should we expand the scope of this PR to make such changes and potentially collaborate on it @soey