refactor: local restore #1919
Open
refactor: local restore #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- I'm trying to write a regression test for #1914. For that I need to setup signal locally. I do it with restoring a backup from one of our demo instances. It turns out that `signal-cli-config` was not restored. Second, I removed obsolete `docker-compose.backup.yml` and unnecessary `tmp/db` folders by just using `docker compose cp`, plus I DRYed the ansible playbook. How to test ----------- 1. `ansible-playbook ansible/restore_locally.yml` 2. Runs faster, no temporary folders created.
mattwr18
reviewed
Jul 2, 2024
There was a problem hiding this comment.
I'm not sure I actually like these changes @roschaefer ... I suggested making similar changes when we introduced the backup of the signal-cli-config and Till pointed out the potential danger in doing so. Have a look.
I have a signal-cli-config for development. Maybe a better solution is to save a zip of this to 1password that you could use whenever you want to test out signal stuff? I also like the idea of not having actual contributors from a production instance in your db while you are testing out Signal since you could easily send out a message to everyone without intending on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm trying to write a regression test for #1914. For that I need to setup signal locally. I do it with restoring a backup from one of our demo instances.
It turns out that
signal-cli-configwas not restored. Second, I removed obsoletedocker-compose.backup.ymland unnecessarytmp/dbfolders by just usingdocker compose cp, plus I DRYed the ansible playbook.How to test
ansible-playbook ansible/restore_locally.yml