Use ALLOCSET_*_SIZES macros to create contexts.

These macros became available in 9.6 (ea268cd, with a "back-patch"
appearing in 9.6.0, funnily enough). It becomes /necessary/ to use
them in PG 11 (9fa6f00), at least when using AllocSetContextCreate
rather than the PG11-new AllocSetContextCreateExtended.

Here, just define the macros locally for PG < 9.6, and use them
unconditionally.

Author: jcflack

pljava-so/src/main/c/type/JavaWrapper.c

@@ -61,9 +61,7 @@ void JavaWrapper_initialize(void)
 
 	JavaMemoryContext = AllocSetContextCreate(TopMemoryContext,
 									 "PL/Java",
-									 ALLOCSET_DEFAULT_MINSIZE,
-									 ALLOCSET_DEFAULT_INITSIZE,
-									 ALLOCSET_DEFAULT_MAXSIZE);
+									 ALLOCSET_DEFAULT_SIZES);
 }
 
 /*

pljava-so/src/main/c/type/Type.c

@@ -402,9 +402,7 @@ Datum Type_invokeSRF(Type self, jclass cls, jmethodID method, jvalue* args, PG_F
 
 		ctxData->rowContext = AllocSetContextCreate(context->multi_call_memory_ctx,
 								  "PL/Java row context",
-								  ALLOCSET_DEFAULT_MINSIZE,
-								  ALLOCSET_DEFAULT_INITSIZE,
-								  ALLOCSET_DEFAULT_MAXSIZE);
+								  ALLOCSET_DEFAULT_SIZES);
 
 		/* Register callback to be called when the function ends
 		 */

pljava-so/src/main/include/pljava/pljava.h

@@ -50,6 +50,20 @@ extern int vsnprintf(char* buf, size_t count, const char* format, va_list arg);
 #define StaticAssertStmt(condition, errmessage)
 #endif
 
+/*
+ * AllocSetContextCreate sprouted these macros for common combinations of
+ * size parameters in PG 9.6. It becomes /necessary/ to use them in PG 11
+ * when using AllocSetContextCreate (which becomes a macro in that version)
+ * and not the (new in that version) AllocSetContextCreateExtended.
+ */
+#if PG_VERSION_NUM < 90600
+#define ALLOCSET_DEFAULT_SIZES \
+	ALLOCSET_DEFAULT_MINSIZE, ALLOCSET_DEFAULT_INITSIZE, ALLOCSET_DEFAULT_MAXSIZE
+#define ALLOCSET_SMALL_SIZES \
+	ALLOCSET_SMALL_MINSIZE, ALLOCSET_SMALL_INITSIZE, ALLOCSET_SMALL_MAXSIZE
+#define ALLOCSET_START_SMALL_SIZES \
+	ALLOCSET_SMALL_MINSIZE, ALLOCSET_SMALL_INITSIZE, ALLOCSET_DEFAULT_MAXSIZE
+#endif
 
 /*
  * GETSTRUCT require "access/htup_details.h" to be included in PG9.3

src/site/markdown/releasenotes.md.vm

@@ -167,6 +167,7 @@ $h3 Updated PostgreSQL APIs tracked
 * `IsBinaryUpgrade`
 * `SPI_register_trigger_data`
 * `SPI` without `SPI_push`/`SPI_pop`
+* `AllocSetContextCreate`
 
 $h2 Earlier releases