Resolve OS X build problems (issue 63). #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the nar-maven-plugin, 'shared' and 'plugin' are interchangeable on platforms other than Darwin, but on Darwin they produce two different link commands (a 'plugin' gets the '-bundle' option). The distinction (on Darwin) is a shared object is something exporting some API that the process loading it will call into, but a plugin/bundle also expects to be able to call back into API provided by the thing that loaded it. PL/Java fits in the second category, so may as well call it a plugin; won't change much on other platforms, but makes a difference on Darwin. When linking a plugin, the Darwin linker wants the -bundle_loader option to identify the program that will be loading the plugin (postgres, in this case). It verifies that the symbols unresolved in the plugin itself really will be found in the program that loads it. Update the packaging script to reflect the change from shared to plugin in the object path.
jcflack
added a commit
that referenced
this pull request
Dec 10, 2015
Merge rebased bug/master/issue63 fix. Before rebasing, this was PR #69 for 3 weeks, and dblanch has confirmed it builds well, so, merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nar-maven-plugin,
sharedandpluginare interchangeable onplatforms other than Darwin, but on Darwin they produce two different
link commands (a
plugingets the-bundleoption).The distinction (on Darwin) is a shared object is something exporting
some API that the process loading it will call into, but a plugin/bundle
also expects to be able to call back into API provided by the thing that
loaded it. PL/Java fits in the second category, so may as well call it a
plugin; won't change much on other platforms, but makes a difference on
Darwin.
When linking a plugin, the Darwin linker wants the
-bundle_loaderoptionto identify the program that will be loading the plugin (postgres, in
this case). It verifies that the symbols unresolved in the plugin itself
really will be found in the program that loads it.
Update the packaging script to reflect the change from
sharedtopluginin the object path.