Alter flow of commission prices control panel #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-organizes control panel into task-oriented rows. - Presently non-functional and should not be merged. - Introduces flexbox for layout.
charmander
reviewed
Jan 10, 2017
| } | ||
|
|
||
| #commishprices-content .di-tags { | ||
| width: 100% |
Remove redundant fields from commission class forms Add preview of price display Fix width of commish-tags column Use radio buttons for cost types
- This is replicated from the profile editting page - It should probably only exist on the commission price page
- Note that this commit depends on some HTML5 features that aren't supported in IE9: formaction, formnovalidate
- Used 'artist' instead of user to distinguish between the user searching and the results - Spelling error and renamed 'artist tags'
…sion class - Without this change, the prices for a deleted commission class would stick around and attach themselves to a new class that took up that id. - In theory there could be a small race condition between these two execute calls where a new commission class is made on the same user at the same time. Does using the same pg_connection for both executes prevent this? Regardless the timing is unlikely to ever come up. - Honestly the world would be much more sane if commission classes used a 'real' primary key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESENTLY NONFUNCTIONAL. DO NOT MERGEShould be functional now.Opening the PR anyway for feedback. Feel free to deracinate this, critique, etc. Frontend is definitely not my forte.
Some notes: