support DataTypeRef for shared strings and worksheet CellsReader #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another iteration at trying to reduce memory usage.
Introduce a new
DataTypeRef
which is the same asDataType
but with an additionalSharedString
variant.The test case from #362 should be amended with:
NOTE:
Given that large test file, we may revisit a protection used against files with mostly blank cells:
https://github.com/tafia/calamine/pull/370/files#diff-bedb7172be56842bcb4be66655e6eb625dadc8a029fe3c87c6657768ef1fc8b9R662