-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_to_end breaks NsReader #597
Labels
Comments
Yes, this is a bug, we should pop the namespace before the returning from the |
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 10, 2023
failures (25): ns_reader.rs (24): reader::ns_reader::read_text::cdata reader::ns_reader::read_text::comment reader::ns_reader::read_text::decl reader::ns_reader::read_text::doctype reader::ns_reader::read_text::empty reader::ns_reader::read_text::pi reader::ns_reader::read_text::start reader::ns_reader::read_text::text reader::ns_reader::read_to_end::cdata reader::ns_reader::read_to_end::comment reader::ns_reader::read_to_end::decl reader::ns_reader::read_to_end::doctype reader::ns_reader::read_to_end::empty reader::ns_reader::read_to_end::pi reader::ns_reader::read_to_end::start reader::ns_reader::read_to_end::text reader::ns_reader::read_to_end_into::cdata reader::ns_reader::read_to_end_into::comment reader::ns_reader::read_to_end_into::decl reader::ns_reader::read_to_end_into::doctype reader::ns_reader::read_to_end_into::empty reader::ns_reader::read_to_end_into::pi reader::ns_reader::read_to_end_into::start reader::ns_reader::read_to_end_into::text issues.rs (1) issue597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Heyo,
The
NsReader::read_to_end
seems to break its ability to resolve namespaces. This makes sense looking at its implementation: It simply delegates to the underlying readers' implementation, without updating its NamespaceResolver:quick-xml/src/reader/ns_reader.rs
Lines 760 to 764 in 9fb797e
Here's a reproducer:
The text was updated successfully, but these errors were encountered: