Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dedicated type for processing instruction #756

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 14, 2024

New type has some useful methods:

  • target() returns target application to what instruction is targeted. Can be empty string
  • content() returns everything else after the target
  • attributes() returns content as an Attributes iterator which is useful for some instructions

Closes #650

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.73134% with 31 lines in your changes missing coverage. Please review.

Project coverage is 61.78%. Comparing base (5d76174) to head (875a10f).
Report is 37 commits behind head on master.

Files Patch % Lines
src/events/mod.rs 41.66% 28 Missing ⚠️
src/writer.rs 0.00% 2 Missing ⚠️
src/writer/async_tokio.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   61.24%   61.78%   +0.53%     
==========================================
  Files          39       41       +2     
  Lines       16277    16773     +496     
==========================================
+ Hits         9969    10363     +394     
- Misses       6308     6410     +102     
Flag Coverage Δ
unittests 61.78% <53.73%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mingun Mingun requested a review from dralley June 14, 2024 15:31
@Mingun Mingun merged commit a44792f into tafia:master Jun 14, 2024
6 checks passed
@Mingun Mingun deleted the pi-type branch June 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing instructions should have a dedicated type
3 participants