Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow when read 4GB+ fiiles on 32-bit targets #769

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 24, 2024

Added new check to CI and check that tests (for sync and async methods) are failed before the fix (I checked) and passed after.

Fixes #751

Commit which is failed before the fix: Mingun@f5608f0
Job result for it: https://github.com/Mingun/quick-xml/actions/runs/9650155180/job/26615200796

@Mingun Mingun requested a review from dralley June 24, 2024 18:27
@Mingun Mingun added the bug label Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 60.28%. Comparing base (7558577) to head (ef954dc).
Report is 47 commits behind head on master.

Files Patch % Lines
src/utils.rs 44.44% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   61.81%   60.28%   -1.54%     
==========================================
  Files          41       41              
  Lines       16798    16226     -572     
==========================================
- Hits        10384     9782     -602     
- Misses       6414     6444      +30     
Flag Coverage Δ
unittests 60.28% <73.33%> (-1.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dralley dralley merged commit d71978e into tafia:master Jun 24, 2024
7 checks passed
@Mingun Mingun deleted the fix-overflows branch June 24, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader<R: BufRead> unnecessarily panics on 32-bit targets when the document size exceeds 4 GiB
3 participants