-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return a Result from Task functions #108
return a Result from Task functions #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really great - think this is even ready to merge except for little things —
One thing:
I’d leave one example where we explictly call the debug_log — we optimized it away from all examples unless I miss something.
Maybe for a case before sending a request?
There was a commented out debug |
Tasks must be converted to return
GooseTaskResult
.This allows the use of
?
as it supports returning a GooseTaskError:Currently we define 3 errors: