Fix uncaught exception of stof #61
Conversation
|
Can confirm fix works on Ubuntu 22.04 |
|
Works for me on Debian GNU/Linux 12 (bookworm) |
|
Works for me as well on Fedora 39 |
|
Can confirm on arch |
|
Hi, New here, how do I fix this with the code? Is there instructions to do that, apologies not too much familiar with GitHub or linux. |
inside the directory for SpeedTest, run |
gh pr checkout 61 then the same install again |
|
There's some extraneous quotes around the IP and ISP when printing the values. I'm not sure if that's due to the explicit casting to strings or if the JSON library you used does something weird? It's not a problem for textual outputs obviously but completely breaks JSON output because that is a simple string concatenation in {"client":{"ip":""x.x.x.x"","lat":"00.0000","lon":"00.0000","isp":""Deutsche Telekom AG""},"servers_online":"10","server":{"name":"Strasbourg","sponsor":"bvpn.eu","distance":"222.986","latency":"23","host":"ookla.de.eu.waselpro.com:8080"},"ping":"23","jitter":"0","_":"only latency requested"}Can be fixed with: try {
map["ip_address"] = obj["ip"].ToString();
map["isp"] = obj["company"]["name"].ToString();
map["lat"] = obj["location"]["latitude"].dump();
map["lon"] = obj["location"]["longitude"].dump();
} catch(...) {} |
SpeedTest.cpp
Outdated
| map["isp"] = (std::ostringstream() << obj["company"]["name"]).str(); | ||
| map["lat"] = (std::ostringstream() << obj["location"]["latitude"]).str(); | ||
| map["lon"] = (std::ostringstream() << obj["location"]["longitude"]).str(); | ||
| map["ip_address"] = static_cast<std::ostringstream &&> |
There was a problem hiding this comment.
Try this instead to correctly dump the strings without extra quotes:
try {
map["ip_address"] = obj["ip"].ToString();
map["isp"] = obj["company"]["name"].ToString();
map["lat"] = obj["location"]["latitude"].dump();
map["lon"] = obj["location"]["longitude"].dump();
} catch(...) {}There was a problem hiding this comment.
I have never tried to output to JSON, so your patch corrects it as well as brings to the code more readability.
Thanks for the fix!
|
Thanks for helping on this! |
* Fix uncaught exception of stof * Another SPEED_TEST_IP_INFO_API_URL with JSON parsing * Added Fixed: link before pull * Fix static_cast<std::ostringstream &&> for type conversion * Removed unused total_size and total_time * JSON output fixed (thanks to ansemjo) (cherry picked from commit b743996)
Fixes #60