Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/DES-2405: Fix tag renaming #110

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Bug/DES-2405: Fix tag renaming #110

merged 4 commits into from
Mar 7, 2023

Conversation

duckonomy
Copy link
Contributor

Overview:

Fix tag renaming regression that happened during refactor.

Related Jira tickets:

Testing Steps:

  1. Create a tag in the Taggit view
  2. Rename the tag
  3. Ensure it is updated

@duckonomy duckonomy marked this pull request as ready for review February 3, 2023 14:13
@nathanfranklin
Copy link
Contributor

nathanfranklin commented Feb 8, 2023 •
edited
Loading

Two things:

  1. I'm having a problem when trying to rename the first of two text tags. If I select to rename the first tag, it always renames the last tag.

  2. Also, when I rename a tag, it loses what type of tag it is which was displayed in parenthesis. For example, "test (text)" becomes "Foo ()".

nathanfranklin
nathanfranklin requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left the one comment: #110 (comment) 👍

@duckonomy
Copy link
Contributor Author

duckonomy commented Mar 7, 2023 •
edited
Loading

I just left the one comment: #110 (comment) 👍

Found a better solution for renaming! No longer produces the bug!

@duckonomy duckonomy merged commit 2874d9e into master Mar 7, 2023
@duckonomy duckonomy deleted the bug/DES-2405-tag-renaming-bug branch March 7, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckonomy @nathanfranklin