Task/DES-2389: CSV/JSON Export #111
Conversation
There was a problem hiding this comment.
Looks good. 👍 I left some comments to consider.
I wonder if some of the issues with "Export to DesignSafe" should be ignored and put in a different follow jira issue that has a low priority. (we could just disable this for now if Fred is okay with that?)
I also wonder if we could just put both the csv and json in the zip. Then we just have one save button that saves a download or saves to DesignSafe. Probably not a priority though.
I found some other bugs unrelated to this PR, that'll I'll document on slack.
|
|
||
| zip.generateAsync({ type: 'blob' }).then((content) => { | ||
| if (forExport) { | ||
| this.filesService.export(systemID, path, fileName, '.zip', content); |
There was a problem hiding this comment.
Export to DesignSafe:
- file exported is not csv but maybe the zip. should the UI be updated
to reflect that? - "If no filename is specified, it will default to the Gallery ID number." I don't think this is no longer true
- when saving a file to DesignSafe if you don't change the name and leave it as "Custom File Name", then it fails as the formname has filename=""
There was a problem hiding this comment.
Adjusted so that it follows the scheme of CSV/JSON export as a fallback.
There was a problem hiding this comment.
Regarding the below comments on "Export to DesignSafe:" menu, I don't think any of these are addressed. The last bullet still fails for me and then I'm still curious about the first two bullets.
- file exported is not csv but maybe the zip. should the UI be updated
to reflect that?- "If no filename is specified, it will default to the Gallery ID number." I don't think this is no longer true
- when saving a file to DesignSafe if you don't change the name and leave it as "Custom File Name", then it fails as the formname has filename=""
I think we can spin them off into another JIRA issue but think they should be noted and followed on.
|
related to #111 (comment), i wonder still abou this
as well as :
thoughts? |
…it-tacc/taggit into task/DES-2389-csv-json-export
Overview:
Fix the CSV/JSON export to work with new structure.
Related Jira tickets:
Testing Steps: