Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted Inventory Screen #31

Merged
merged 6 commits into from
Oct 19, 2017
Merged

Formatted Inventory Screen #31

merged 6 commits into from
Oct 19, 2017

Conversation

ldaw
Copy link
Contributor

@ldaw ldaw commented Oct 17, 2017

In response to issue #22, created and implemented private Player functions printDivider, printXPBar, and printInventoryItem to automatically print formatted inventory lines of a fixed width.

Created and implemented private Player functions printDivider, printXPBar, and printInventoryItem to automatically print formatted inventory lines of a fixed width
Corrected lack of scope operators
Copy link
Owner

@tagniam tagniam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! The small thing I would change is the method name casing. CamelCase for methods instead of camelCase.

@ldaw
Copy link
Contributor Author

ldaw commented Oct 19, 2017

Alright, I'll try to get that done tomorrow!

Reformatted method names to CamelCase
Reformatted method names to CamelCase
@ldaw
Copy link
Contributor Author

ldaw commented Oct 19, 2017

Okay, I fixed the method names! Their member variables are still camelCased, hope that's not an issue.

@tagniam tagniam merged commit e709c43 into tagniam:master Oct 19, 2017
@tagniam
Copy link
Owner

tagniam commented Oct 19, 2017

Great work @ldaw! Thanks for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants