Displays missing item in battle #44
Conversation
|
@mario51y1 It looks like there's a bug where if you repeatedly use an item not in the inventory, the enemy will heal themselves instead of doing nothing. |
Turn/src/Game.cpp
Outdated
| // Player's turn to attack Enemy. | ||
| _Enemy->TakeDamage(_Player->Attack()); | ||
|
|
||
| _Enemy->TakeDamage(damagePlayer); |
There was a problem hiding this comment.
Bug occurs here, when damagePlayer = 2, 2 points are added to enemy's health (which makes it look like it's healing)
|
Yeah, thought I made the if statement that checks the damage but seems it's missing. |
|
Could you make -2 a constant, like SKIP_TURN? This will ensure readability |
Turn/src/Player.cpp
Outdated
| @@ -114,8 +114,10 @@ int Player::Attack(){ | |||
| { | |||
| PlaySecondaryAttack(); | |||
| return BowAndArrow(); | |||
| } | |||
Turn/src/Player.cpp
Outdated
| case 7: | ||
| // Player sharpens their weapon with a whetstone. | ||
| // Does not execute if there are no whetstones in inventory. | ||
| // No damage is done to the enemy. | ||
| if (whetstones > 0) { | ||
| UseWhetstone(); | ||
| return 0; | ||
| } else { | ||
| cout << "No whetsones in the inventory!" << endl; |
Turn/src/Player.cpp
Outdated
| } | ||
| break; | ||
| else | ||
| cout << "No arrows in the inventory!" << endl; |
There was a problem hiding this comment.
Wrap this else block with curly braces
Turn/src/Player.cpp
Outdated
| @@ -126,24 +128,30 @@ int Player::Attack(){ | |||
| // Does not execute if there are no bombs in the inventory. | |||
| if (bombs > 0) | |||
| return UseBomb(); | |||
| break; | |||
| else | |||
There was a problem hiding this comment.
Wrap this else block with curly braces
|
Also, weirdly when I try to use a non-existent item, the message is displayed twice as long. |
|
Ok, so is something else missing? Had some troubles with visual sutudio and I couldnt test if everything is working as suposed. |
|
Thanks for the patience while I reviewed this PR @mario51y1. Everything's good now, I just had to fix a little bug in the code but it's all working now. Happy hacktoberfest! 🎃 |
|
Thanks for your patience as well working wiht a newbie in GitHub, I'm happy that evertyhing is working now. Happy Hacktoberfest too! 🎃 |
|
I was in your position as a newbie on github just a few years ago, everyone starts somewhere 😄 Hope you continue to contribute to open source in the future! |
refers #41