Implemented an in-game store #49 #53
Conversation
Turn/src/Store.cpp
Outdated
| { | ||
| ClearScreen(); | ||
| coins = _Player->GetCoins(); | ||
| cout << endl << " Jeremy's Tools Store\tPlayer: "; |
There was a problem hiding this comment.
I suggest that Player::DisplayInventory is called here instead of just printing the player's coins. This way they know what it is in their inventory when they're buying something.
Turn/src/Store.cpp
Outdated
| _Player->AddStoreItemToInventory(ITEMTYPE::BOMB); | ||
| _Player->LoseCoins(bombCost); | ||
| } | ||
| Sleep(1000); |
There was a problem hiding this comment.
Use SLEEP_MS instead of a magic number. Same thing for the other cases
There was a problem hiding this comment.
done all the changes suggested
Turn/src/Store.cpp
Outdated
| cout << " 0) Exit" << endl << endl; | ||
| cout << " -------------------------------------------- " << endl << endl; | ||
| cout << " What do you want to buy today?" << endl << endl << " "; | ||
| cin >> choice; |
There was a problem hiding this comment.
It would be nice if choice = input(); is used instead
Turn/src/Store.cpp
Outdated
| const unsigned short whetstoneCost = 20; | ||
|
|
||
| //Messages | ||
| string lowCoinsMessage = " Insufficient Coins !"; |
There was a problem hiding this comment.
These strings should be constant
There was a problem hiding this comment.
should i move all the const values such as Cost and Messages to common.h and common.cpp ?
|
Nice work @sarthi92, thank you for making the game better 👍 |
Implemented Store