Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gender to player #71

Merged
merged 3 commits into from
Oct 28, 2017
Merged

Adds gender to player #71

merged 3 commits into from
Oct 28, 2017

Conversation

chuck-sys
Copy link
Contributor

Adds gendered pronouns to dialog.

With reference to #68.

Copy link
Owner

@tagniam tagniam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggested changes

<< endl << endl
<< "> ";

cin >> gender;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that gender is converted to uppercase so that both upper/lower case m/f works

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ClearScreen() should be called after every iteration in the while loop

@tagniam tagniam merged commit 246842a into tagniam:master Oct 28, 2017
@tagniam
Copy link
Owner

tagniam commented Oct 28, 2017

Thanks for the contribution @cheukyin699!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants