Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format inventory screen #22

Closed
tagniam opened this issue Oct 13, 2017 · 6 comments
Closed

Format inventory screen #22

tagniam opened this issue Oct 13, 2017 · 6 comments

Comments

@tagniam
Copy link
Owner

tagniam commented Oct 13, 2017

Right now the inventory looks like this.

*----------- INVENTORY -----------*
Level 2                 0/100 xp
| Arrows: [10]
| Potions: [0]
| Bombs: [3]
| Whetstones: [0]
| Weapon strength: [100%]
| Wealth: [48] coins
*---------------------------------*

3 things need to be implemented:

  1. Put a divider between the level/xp line and the items
  2. Draw a right side to the inventory box
  3. xp needs to be aligned to the right, with 1 space padding

So it would end up looking like this diagram, labelled:

*----------- INVENTORY -----------*
| Level 2                0/100 xp | <- 3
+---------------------------------+ <- 1
| Arrows: [10]                    |
| Potions: [0]                    |
| Bombs: [3]                      | <- 2
| Whetstones: [0]                 |
| Weapon strength: [100%]         | 
| Wealth: [48] coins              |
*---------------------------------*

You will have to do some character counting when implementing 2 and 3, since as the values add digits, less spaces will be needed.

@SoumyadeepJana
Copy link

Working on it!

@sgrG24
Copy link

sgrG24 commented Oct 13, 2017

can i also work on it??

@SoumyadeepJana
Copy link

I don't think chracter counting is needed if you keep a mximum width

@ldaw
Copy link
Contributor

ldaw commented Oct 17, 2017

I made a functional solution for this issue, I'll submit a PR soon.

@ldaw
Copy link
Contributor

ldaw commented Oct 17, 2017

Just submitted my PR. Let me know if there are any issues, I didn't get to test it with the full project but it worked perfectly with a driver I wrote.

@tagniam
Copy link
Owner Author

tagniam commented Oct 19, 2017

Fixed by #31

@tagniam tagniam closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants