feat(parser) Implement `class-constant-access-expression` #116

Hywan · 2017-09-12T14:00:02Z

Address #68.

Try to implement the `class-constant-access-expression`. To avoid an infinite type size, it is required to change the definition of `DereferencableExpression` a little bit by adding `Box` to `Expression` and `Array` variants.

It tries to implement the `class-constant-access-expression` rule.

`class_constant_access` can create a conflict with other parsers like `literal` or `array`. To avoid stopping at an `Incomplete` and try another branch of the `alt!` macro, it is replaced by `alt_complete!`. `class_constant_access` is also moved to the last branches of `alt_complete!` to avoid many backtracks.

coveralls · 2017-09-12T16:27:34Z

Coverage decreased (-0.05%) to 95.63% when pulling f22dba1 on Hywan:class-constant-access into 338bc27 on tagua-vm:master.

coveralls · 2017-09-12T16:27:34Z

Coverage decreased (-0.05%) to 95.63% when pulling f22dba1 on Hywan:class-constant-access into 338bc27 on tagua-vm:master.

coveralls · 2017-09-12T17:44:07Z

Coverage decreased (-0.05%) to 95.63% when pulling f22dba1 on Hywan:class-constant-access into 338bc27 on tagua-vm:master.

coveralls · 2017-09-12T17:44:08Z

Coverage decreased (-0.05%) to 95.63% when pulling f22dba1 on Hywan:class-constant-access into 338bc27 on tagua-vm:master.

Hywan added 8 commits September 11, 2017 17:36

feat(ast) Add Expression::ClassConstantAccess.

fbf0d8a

Try to implement the `class-constant-access-expression`. To avoid an infinite type size, it is required to change the definition of `DereferencableExpression` a little bit by adding `Box` to `Expression` and `Array` variants.

feat(parser) Add class_constant_access.

a982ece

It tries to implement the `class-constant-access-expression` rule.

test(parser) Add cases for class_constant_access.

a1a1a92

chore(doc) Format.

3325a46

doc(ast) Explain Expression::ClassConstantAccess.

994b7a4

doc(ast) Explain DereferencableExpression.

fac11d1

doc(ast) Explain ScopeResolver.

51f7ada

Hywan added component-ast component-documentation component-grammar component-test enhancement in progress labels Sep 12, 2017

Hywan added this to the 0.2.0 milestone Sep 12, 2017

Hywan self-assigned this Sep 12, 2017

fix(parser) Add first! in class_constant_access.

f22dba1

Hywan merged commit f22dba1 into tagua-vm:master Sep 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(parser) Implement `class-constant-access-expression` #116

feat(parser) Implement `class-constant-access-expression` #116

Hywan commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017

feat(parser) Implement class-constant-access-expression #116

feat(parser) Implement class-constant-access-expression #116

Conversation

Hywan commented Sep 12, 2017 • edited

coveralls commented Sep 12, 2017 • edited

coveralls commented Sep 12, 2017 • edited

coveralls commented Sep 12, 2017 • edited

coveralls commented Sep 12, 2017

feat(parser) Implement `class-constant-access-expression` #116

feat(parser) Implement `class-constant-access-expression` #116

Hywan commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited

coveralls commented Sep 12, 2017 •

edited