Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load video if onboarding skipped #654

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

xpaczka
Copy link
Contributor

@xpaczka xpaczka commented Nov 8, 2023

Resolves #652

What has been done:

  • Moves DApps to ui folder
  • Video is only loaded when user is not onboarded

@xpaczka xpaczka self-assigned this Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for taho-development ready!

Name Link
🔨 Latest commit 2395dd0
🔍 Latest deploy log https://app.netlify.com/sites/taho-development/deploys/654b6a47925942000873317d
😎 Deploy Preview https://deploy-preview-654--taho-development.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

import PrivacyPolicy from "../../shared/components/PrivacyPolicy"
import IslandView from "./IslandView"

function TrackEvents({ children }: { children: ReactNode[] }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we quickly make it a hook not component?

Copy link
Contributor

@jagodarybacka jagodarybacka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine, let's fix the TrackEvents in the next PR

@jagodarybacka jagodarybacka merged commit 1e5df84 into main Nov 8, 2023
4 checks passed
@jagodarybacka jagodarybacka deleted the loading-assets branch November 8, 2023 11:18
jagodarybacka added a commit that referenced this pull request Nov 9, 2023
Ref #654 

Transform `TrackEvents` component into `useTrackEvents` hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video still loading if onboarding skipped
2 participants