Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max button precision by passing correct arguments #692

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jagodarybacka
Copy link
Contributor

Resolves: #688

What

  • Make it possible to stake/unstake amounts less than 0.01 TAHO
  • Make "max" button pass the numbers with full precision
  • DIsplay small amounts in the stake/unstake headers

image

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for taho-development ready!

Name Link
🔨 Latest commit a748390
🔍 Latest deploy log https://app.netlify.com/sites/taho-development/deploys/65539a2981d3240008ae1de2
😎 Deploy Preview https://deploy-preview-692--taho-development.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ioay ioay merged commit 297637d into main Nov 14, 2023
4 checks passed
@ioay ioay deleted the max-button-precision branch November 14, 2023 16:18
@andreachapman
Copy link
Contributor

andreachapman commented Nov 14, 2023

@jagodarybacka - so I was able to successfully unstake very small amounts from an account that was already past the cooldown period. I did multiple increments like .01 and .001 until I finally had only .001 remaining and then I was able to use the Max button and it unstaked the whole amount.

However, I see something a little odd when I stake an amount that small. So here, `0x50f5f766db5b6ce04f4eacede11e1bf96d6d986e' I staked .005 and under the Staked portion, it shows that remaining TAHO correctly. But under Unstake where we see it's still in the cooldown, it shows 0. I have to wait for the cooldown to expire before I can see if it then changes that to .005 and I'll update this comment once I verify that.
Screenshot 2023-11-14 at 11 53 27 AM

Also, and I know this isn't related to the dapp but do we need a ticket for the wallet to show TAHO and VeTAHO at such precision? It currently only shows to .00.
Screenshot 2023-11-14 at 11 59 14 AM

In that screenshot, you can again see that at least while it's in the cooldown, the Unstake side is only showing the amount to the .00 and not more precise than that.

I'll come back and update this after the cooldown expires but my feeling is that it doesn't show the full precision until after the cooldown - because I definitely saw much smaller amounts earlier and could unstake them.

Edit: after the cooldown expired, you can see the second account now shows the greater precision under the Unstake header than it did when it was in the cooldown period:

Screenshot 2023-11-14 at 12 42 42 PM

@andreachapman
Copy link
Contributor

Actually, @jagodarybacka - I can confirm that the precision shown on the Unstake is different when it's in the cooldown. So the above screenshots show on that's still within the cooldown and this is one that wasn't:
Screenshot 2023-11-14 at 12 18 59 PM

And you can see greater precision here.

But what I'm not sure about is if we want to go ahead and ship this as-is since it fixes the reported problem and then iterate later on what we're seeing during the cooldown. I would assume that's the better path forward rather than holding this one up. But let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Max" button on stake/unstake
3 participants