Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFB 4: One-Off Keyring Design #3372

Merged
merged 5 commits into from
May 12, 2023
Merged

RFB 4: One-Off Keyring Design #3372

merged 5 commits into from
May 12, 2023

Commits on May 9, 2023

  1. Add RFB 4 with the one-off private key design 

    This describes the changes between RFB 1 and the
private-key-and-export-supporting InternalSignerService.
    @Shadowfiend
    Shadowfiend committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6c71c8d View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Fix BIP32 reference in RFB-4

    @Shadowfiend
    Shadowfiend committed May 11, 2023
    Configuration menu
    Copy the full SHA
    27545a7 View commit details
    Browse the repository at this point in the history

  2. Consistently reference HDKeyring instead of "HD Wallet" in RFB-4

    @Shadowfiend
    Shadowfiend committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b8a5a55 View commit details
    Browse the repository at this point in the history

  3. Explicitly note no JSON exports in RFB-4

    @Shadowfiend
    Shadowfiend committed May 11, 2023
    Configuration menu
    Copy the full SHA
    88608f2 View commit details
    Browse the repository at this point in the history

  4. Make future improvement a current improvement in RFB 4 

    We decided to go ahead and implement tracking a given address in only
one place (keychain if available, otherwise private key).
    @Shadowfiend
    Shadowfiend committed May 11, 2023
    Configuration menu
    Copy the full SHA
    745c21a View commit details
    Browse the repository at this point in the history