Allow setting custom auto-lock timer #3477

hyphenized · 2023-06-14T04:36:09Z

Adds a dropdown on settings to allow changing the maximum amount of time the wallet can remain idle before locking signing. This new setting is updated through an async thunk which triggers an event to also handle the change on the keyring service. The data is persisted on preferences db and exposed through redux to the UI.

Testing Env

SUPPORT_CUSTOM_AUTOLOCK=true

To Test

Import an account
Lock and unlock your wallet
Head to settings, change auto-lock time
Change your system's date or change the options here, test that different time options work correctly
If the wallet has been idle for 10 minutes and the current auto lock setting changes to from 15 minutes to 5, the wallet should lock itself.

Latest build: extension-builds-3477 (as of Thu, 22 Jun 2023 16:11:15 GMT).

jagodarybacka

Haven't tested yet, some quick comments

.env.defaults

background/redux-slices/ui.ts

background/services/keyring/index.ts

jagodarybacka · 2023-06-16T15:16:34Z

Hmm, Github isn't running checks for PRs to non-main branches, there is a problem with nonexisting variable reference, I'll fix it quickly

EDIT Ok now checks are running, they broke because of force push I guess...

jagodarybacka · 2023-06-16T15:36:37Z

if we are dropping a flag for private keys then I think we can release this thing in the same release as well and we can omit the feature flag here 🤔

jagodarybacka

Updated with the newest main changes so we can QA it here. Overall looks wonderful! I think we can drop the flag 🏳️

Shadowfiend · 2023-06-16T20:11:57Z

background/main.ts

+      await this.preferenceService.updateAutoLockTimer(newTimerValue)
+      await this.internalSignerService.updateAutoLockTimer()


We discussed some of this elsewhere, but let's update the PreferenceService and then let InternalSignerService observe the change via that service, rather than acting on both of them. Similarly, let's let that PreferenceService change dispatch the setAutoLockTimer action on the store. Otherwise we can end up with UI/backend drift that could trigger some weird edge cases.

Shadowfiend

Left a couple of notes around naming, typing, and data flow.

background/services/preferences/defaults.ts

background/services/internal-signer/index.ts

ui/pages/Settings.tsx

Shadowfiend · 2023-06-16T20:21:37Z

ui/pages/Settings.tsx

@@ -324,7 +397,7 @@ export default function Settings(): ReactElement {
    ),
  }

-  const settings = Object.values({
+  const settings: SettingsList = {


Any reason this isn't just an array? Doesn't look like we're using the key for anything.

It actually feels like we could straightforwardly use the key for i18n purposes, iterating Object.entries and skipping the title field, so we have a { [titleKey: string]: SettingsItem[] }.

Not blocking ofc.

No reason but also didn't consider it blocking. We could use Object.entries but we'd have to do some casting since translations are typed and expect a valid dictionary key.

This is already changed here and on Flashbots PR as it was causing conflicts, I think we should unify it separately from both PRs to make them all compatible

We could use Object.entries but we'd have to do some casting since translations are typed and expect a valid dictionary key.

I hate this about Object.entries 🙃

jagodarybacka · 2023-06-22T09:39:23Z

@hyphenized could you resolve conflicts? I can test it one more time and I think it will be good to go

jagodarybacka · 2023-06-22T15:00:47Z

I realized we are not mentioning what unit we are using here, pretty obvious that these are minutes but maybe not 🤔 cc @VladUXUI

EDIT: I see on Figma there are indeed units there

jagodarybacka

Works fine ✅

Requests addressed

@jagodarybacka

## What's Changed * Add private key onboarding flow by @jagodarybacka in #3119 * Private key JSON import by @jagodarybacka in #3177 * Allow export of private keys and mnemonics by @jagodarybacka in #3248 * Export private key form by @jagodarybacka in #3255 * Unlock screen for the account backup by @kkosiorowska in #3257 * Show mnemonic menu by @jagodarybacka in #3259 * Fix background blur issue by @jagodarybacka in #3265 * Account backup UI fixes by @jagodarybacka in #3270 * Fix unhiding removed accounts by @jagodarybacka in #3282 * New error for incorrectly decrypted JSON file by @jagodarybacka in #3293 * Export private keys from HD wallet addresses by @jagodarybacka in #3253 * Refactor keyring redux slice to remove `importing` field by @jagodarybacka in #3309 * 📚 Accounts backup by @kkosiorowska in #3252 * Catch Enter keypress on Unlock screen by @jagodarybacka in #3355 * Rename `keyring` to `internal signer` and other improvements by @jagodarybacka in #3331 * 🗝 QA - Accounts backup and private key import by @jagodarybacka in #3266 * Remove private key signers if they are replaced by accounts from HD wallet by @jagodarybacka in #3377 * RFB 4: One-Off Keyring Design by @Shadowfiend in #3372 * Copy to clipboard warning by @kkosiorowska in #3488 * Allow setting custom auto-lock timer by @hyphenized in #3477 * Use Argon2 for encrypted vaults by @jagodarybacka in #3502 * 👑 Private keys import and accounts backup by @jagodarybacka in #3089 * Untrusted assets should not block the addition of custom tokens by @kkosiorowska in #3491 * Flip updated dApp connections flag by @Shadowfiend in #3492 * v0.41.0 by @Shadowfiend in #3531 * Switch to a given network if adding a network that is already added. by @0xDaedalus in #3154 * Remove waiting for Loading Doggo component in E2E tests by @jagodarybacka in #3541 * Squeeze content to better fit on Swaps page by @jagodarybacka in #3542 * Refactor of terms for verified/unverified assets by @kkosiorowska in #3528 * Fix ChainList styling by @fulldecent in #3547 * Update release checklist by @jagodarybacka in #3548 * Fix custom asset price fetching by @hyphenized in #3508 * Sticky Defaults: Make Taho-as-default replace MetaMask in almost all cases by @Shadowfiend in #3546 ## New Contributors * @fulldecent made their first contribution in #3547 **Full Changelog**: v0.41.0...v0.42.0 Latest build: [extension-builds-3549](https://github.com/tahowallet/extension/suites/14268975651/artifacts/801826435) (as of Thu, 13 Jul 2023 09:51:56 GMT).

hyphenized requested a review from a team June 14, 2023 04:36

hyphenized requested a review from a team as a code owner June 14, 2023 04:36

jagodarybacka reviewed Jun 14, 2023

View reviewed changes

.env.defaults Outdated Show resolved Hide resolved

background/redux-slices/ui.ts Outdated Show resolved Hide resolved

background/services/keyring/index.ts Outdated Show resolved Hide resolved

hyphenized added 8 commits June 14, 2023 13:57

Add custom autolock feature flag

30ab224

Add auto-lock timer dropdown to settings

f5253aa

Update default preferences

47bbaf0

Add selector & migration

ffd4749

Wire up autolock timer settings to keyring service

9936344

Fix incorrect lock time values

260fbfb

Update auto lock tests

b1e210a

Add custom lock timer test

b95c535

hyphenized force-pushed the locked-and-loaded branch from e9100f5 to b95c535 Compare June 14, 2023 19:11

hyphenized requested a review from a team as a code owner June 14, 2023 19:11

hyphenized changed the base branch from main to keyring-with-pk June 14, 2023 19:11

Fix old KeyringTypes reference

b0d3743

Merge branch 'keyring-with-pk' into locked-and-loaded

9bcb3f3

jagodarybacka approved these changes Jun 16, 2023

View reviewed changes

Remove feature flag

403bc54

hyphenized force-pushed the locked-and-loaded branch from 298bcd4 to 403bc54 Compare June 16, 2023 16:26

Fix invalid migration

e0f0251

Shadowfiend reviewed Jun 16, 2023

View reviewed changes

Shadowfiend previously requested changes Jun 16, 2023

View reviewed changes

hyphenized added 3 commits June 18, 2023 22:00

Improve naming on auto lock interval

2790f3b

Move constant to the top level of the module

f765003

Refactor to observe auto lock settings changes

6824f06

hyphenized force-pushed the locked-and-loaded branch from 0fb2a97 to 6824f06 Compare June 19, 2023 03:00

Merge branch 'keyring-with-pk' into locked-and-loaded

298d19e

Add missing units to auto lock timer settings

86dd6d8

jagodarybacka approved these changes Jun 23, 2023

View reviewed changes

jagodarybacka merged commit 2c1816b into keyring-with-pk Jun 23, 2023

jagodarybacka deleted the locked-and-loaded branch June 23, 2023 08:27

kkosiorowska mentioned this pull request Jul 13, 2023

v0.42.0 #3549

Merged

beemeeupnow mentioned this pull request Aug 5, 2023

Make auto lock timer a menu adjustable parameter #1151

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow setting custom auto-lock timer #3477

Allow setting custom auto-lock timer #3477

hyphenized commented Jun 14, 2023 •

edited by github-actions bot

Loading

jagodarybacka left a comment

jagodarybacka commented Jun 16, 2023 •

edited

Loading

jagodarybacka commented Jun 16, 2023

jagodarybacka left a comment

Shadowfiend Jun 16, 2023

Shadowfiend left a comment

Shadowfiend Jun 16, 2023

hyphenized Jun 19, 2023

jagodarybacka Jun 19, 2023

Shadowfiend Jun 20, 2023

jagodarybacka commented Jun 22, 2023

jagodarybacka commented Jun 22, 2023 •

edited

Loading

jagodarybacka left a comment

		await this.preferenceService.updateAutoLockTimer(newTimerValue)
		await this.internalSignerService.updateAutoLockTimer()

Allow setting custom auto-lock timer #3477

Allow setting custom auto-lock timer #3477

Conversation

hyphenized commented Jun 14, 2023 • edited by github-actions bot Loading

Testing Env

To Test

jagodarybacka left a comment

Choose a reason for hiding this comment

jagodarybacka commented Jun 16, 2023 • edited Loading

jagodarybacka commented Jun 16, 2023

jagodarybacka left a comment

Choose a reason for hiding this comment

Shadowfiend Jun 16, 2023

Choose a reason for hiding this comment

Shadowfiend left a comment

Choose a reason for hiding this comment

Shadowfiend Jun 16, 2023

Choose a reason for hiding this comment

hyphenized Jun 19, 2023

Choose a reason for hiding this comment

jagodarybacka Jun 19, 2023

Choose a reason for hiding this comment

Shadowfiend Jun 20, 2023

Choose a reason for hiding this comment

jagodarybacka commented Jun 22, 2023

jagodarybacka commented Jun 22, 2023 • edited Loading

jagodarybacka left a comment

Choose a reason for hiding this comment

hyphenized commented Jun 14, 2023 •

edited by github-actions bot

Loading

jagodarybacka commented Jun 16, 2023 •

edited

Loading

jagodarybacka commented Jun 22, 2023 •

edited

Loading