Disable abilities extension-wide #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way that abilities are currently implemented, load on the Daylight API side is very high. We don't have the cycles right now to implement the underlying changes that would improve API load, so for now we disable abilities fetching, as well as access to abilities in the UI. The code that is commented out is targeted to only remove the parts that link to the abilities UI and the parts that call out to the Daylight API; the rest remains in place so that turning things back on once the fetching strategy can be improved is straightforward.
Shadowfiend
force-pushed
the
disable-abilities
branch
from
4e0e2ef
to
4bd1bb9
Compare
|
Turboing this for release. |
Merged
Shadowfiend
added a commit
that referenced
this pull request
Feb 19, 2024
## What's Changed * v0.56.0 by @Shadowfiend in #3729 * Drop Arbitrum Sepolia from Alchemy supported network ids by @Shadowfiend in #3730 * Disable abilities extension-wide by @Shadowfiend in #3734 **Full Changelog**: v0.56.0...v0.57.0 Latest build: [extension-builds-3735](https://github.com/tahowallet/extension/suites/20840877238/artifacts/1252537126) (as of Fri, 16 Feb 2024 22:05:55 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way that abilities are currently implemented, load on the Daylight API side is very high. We don't have the cycles right now to implement the underlying changes that would improve API load, so for now we disable abilities fetching, as well as access to abilities in the UI.
The code that is commented out is targeted to only remove the parts that link to the abilities UI and the parts that call out to the Daylight API; the rest remains in place so that turning things back on once the fetching strategy can be improved is straightforward.
Latest build: extension-builds-3734 (as of Fri, 16 Feb 2024 21:10:27 GMT).