Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check version number before uploading to pypi #5824

Closed
ailzhang opened this issue Aug 18, 2022 · 0 comments
Closed

Check version number before uploading to pypi #5824

ailzhang opened this issue Aug 18, 2022 · 0 comments
Assignees
@feisuzhu
Labels
feature request Suggest an idea on this project release
Milestone
v1.4.0

Comments

@ailzhang
Copy link
Contributor

I forgot to upgrade version number in rc-v1.1.1 branch and had to yank this release due to the following two issues:

  • some of the built wheels have 1.1.0 in their names which is unexpected, they should use 1.1.1 which is manually specified when I started the workflow.
  • can we also add another check to make sure the version printed in ti.init aligns with tagged version before uploading to pypi?

workflow: https://github.com/taichi-dev/taichi/runs/7898021397?check_suite_focus=true
@ailzhang ailzhang added the feature request Suggest an idea on this project label Aug 18, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Aug 18, 2022
@ailzhang ailzhang added this to the v1.1.3 milestone Aug 23, 2022
@ailzhang ailzhang moved this from Untriaged to Todo in Taichi Lang Aug 26, 2022
@victoriacity victoriacity moved this from Todo to Backlog in Taichi Lang Sep 16, 2022
@strongoier strongoier modified the milestones: v1.1.3, v1.1.4 Sep 20, 2022
@jim19930609 jim19930609 modified the milestones: v1.1.4, v1.2.0 Oct 18, 2022
@ailzhang ailzhang modified the milestones: v1.2.0, v1.3.0 Nov 10, 2022
@PENGUINLIONG PENGUINLIONG modified the milestones: v1.3.0, v1.4.0 Nov 25, 2022
@feisuzhu feisuzhu mentioned this issue Jan 5, 2023
Merged
feisuzhu added a commit that referenced this issue Jan 5, 2023
@feisuzhu
[ci] Version sanity check before publishing (#7062)
a034184 
Issue: #5824 

### Brief Summary
@feisuzhu feisuzhu closed this as completed Jan 5, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Taichi Lang Jan 5, 2023
PGZXB pushed a commit to PGZXB/taichi that referenced this issue Jan 5, 2023
@feisuzhu @PGZXB
[ci] Version sanity check before publishing (taichi-dev#7062)
dfe0a2e 
Issue: taichi-dev#5824 

### Brief Summary
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@feisuzhu @quadpixels
[ci] Version sanity check before publishing (taichi-dev#7062)
4614b34 
Issue: taichi-dev#5824 

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feisuzhu feisuzhu

Labels
feature request Suggest an idea on this project release
Projects
Taichi Lang
Status: Done
Milestone
v1.4.0
Development

No branches or pull requests
5 participants
@feisuzhu @PENGUINLIONG @strongoier @ailzhang @jim19930609