Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Experimental SpMV and direct linear solvers #2853

Merged
merged 21 commits into from
Sep 3, 2021
Merged

[Lang] Experimental SpMV and direct linear solvers #2853

merged 21 commits into from
Sep 3, 2021

Conversation

FantasyVR
Copy link
Collaborator

Related pr = #2657 and #2792

In this pr, sparse matrix-vector multiplication and direct linear solvers (LLT, LDLT, LU) are supported.

@FantasyVR FantasyVR requested review from k-ye, yuanming-hu, ltt1598 and squarefk and removed request for k-ye August 31, 2021 09:01
@FantasyVR
Copy link
Collaborator Author

/format

@FantasyVR
Copy link
Collaborator Author

/format

yuanming-hu
yuanming-hu reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just some minor comments.

taichi/program/sparse_matrix.cpp Outdated Show resolved Hide resolved
taichi/program/sparse_solver.h Outdated Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
python/taichi/lang/sparse_matrix.py Outdated Show resolved Hide resolved
@FantasyVR
Copy link
Collaborator Author

/format

yuanming-hu
yuanming-hu reviewed Sep 1, 2021
View reviewed changes
python/taichi/lang/sparse_matrix.py Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
tests/python/test_sparse_linear_solver.py Outdated Show resolved Hide resolved
taichi/python/export_lang.cpp Outdated Show resolved Hide resolved
@FantasyVR
Copy link
Collaborator Author

/format

yuanming-hu
yuanming-hu approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Please feel free to merge after these minor issues are fixed.

taichi/program/sparse_solver.cpp Outdated Show resolved Hide resolved
python/taichi/lang/sparse_matrix.py Outdated Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
python/taichi/lang/sparse_solver.py Outdated Show resolved Hide resolved
@yuanming-hu yuanming-hu changed the title [Lang] Experimental SpMV and direct linear solver [Lang] Experimental SpMV and direct linear solvers Sep 2, 2021
FantasyVR and others added 2 commits September 3, 2021 00:30
@FantasyVR @yuanming-hu
Format
e67f68b 
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@FantasyVR
Reports whether previous computation was successful.
82b1c67
@yuanming-hu yuanming-hu merged commit 7656b4a into taichi-dev:master Sep 3, 2021
@FantasyVR FantasyVR deleted the smpv branch September 3, 2021 09:24
This was referenced Sep 9, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@k-ye k-ye Awaiting requested review from k-ye

@ltt1598 ltt1598 Awaiting requested review from ltt1598

@squarefk squarefk Awaiting requested review from squarefk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FantasyVR @yuanming-hu @taichi-gardener