Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Call external function with llvm bitcode #2873

Merged
merged 55 commits into from
Nov 3, 2021
Merged

[Lang] Call external function with llvm bitcode #2873

merged 55 commits into from
Nov 3, 2021

Conversation

squarefk
Copy link
Contributor

@squarefk squarefk commented Sep 5, 2021

Related issue = #

@squarefk
Copy link
Contributor Author

squarefk commented Sep 5, 2021

/format

1 similar comment
@squarefk
Copy link
Contributor Author

squarefk commented Sep 5, 2021

/format

k-ye
k-ye reviewed Sep 6, 2021
View reviewed changes
taichi/ir/statements.h Outdated Show resolved Hide resolved
@k-ye
Copy link
Member

k-ye commented Sep 6, 2021

Let's create an issue to track this work :-)

@squarefk squarefk mentioned this pull request Sep 6, 2021
Open
@squarefk
Copy link
Contributor Author

squarefk commented Sep 6, 2021

#2879

@squarefk
Copy link
Contributor Author

squarefk commented Sep 8, 2021

/format

@squarefk squarefk requested a review from k-ye September 8, 2021 06:51
@squarefk
Copy link
Contributor Author

squarefk commented Sep 8, 2021

/format

k-ye
k-ye reviewed Sep 9, 2021
View reviewed changes
taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved
misc/demo_call_cpp.py Outdated Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

squarefk commented Sep 9, 2021

/format

@squarefk
Copy link
Contributor Author

/format

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

❌ Deploy Preview for jovial-fermat-aa59dc failed.

🔨 Explore the source changes: f446670

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6180c05b6e9515000840a5a8

@squarefk
Copy link
Contributor Author

/format

@squarefk
Copy link
Contributor Author

/format

@squarefk squarefk requested a review from k-ye September 17, 2021 02:49
k-ye
k-ye reviewed Sep 17, 2021
View reviewed changes
python/taichi/lang/source_builder.py Outdated Show resolved Hide resolved
python/taichi/lang/source_builder.py Outdated Show resolved Hide resolved
python/taichi/lang/source_builder.py Outdated Show resolved Hide resolved
python/taichi/lang/ops.py Outdated Show resolved Hide resolved
@k-ye k-ye requested a review from ailzhang October 15, 2021 01:59
@k-ye k-ye requested a review from strongoier October 26, 2021 05:46
strongoier
strongoier reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

  1. Remember to cancel your accidental modification to SPIRV-Headers
  2. Modifications to control_flow_graph.cpp should be removed as we support CFG optimization for local tensors now ([opt] Enable CFG optimization for local tensors #3237)

python/taichi/lang/ops.py Outdated Show resolved Hide resolved
taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved
taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

squarefk commented Nov 1, 2021

/format

@squarefk
Copy link
Contributor Author

squarefk commented Nov 1, 2021

/format

ailzhang
ailzhang approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! (sorry for the late review!)

python/taichi/lang/source_builder.py Outdated Show resolved Hide resolved
python/taichi/lang/util.py Show resolved Hide resolved
taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved
taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

squarefk commented Nov 2, 2021

/format

@squarefk
Copy link
Contributor Author

squarefk commented Nov 2, 2021

/format

@squarefk squarefk merged commit 22fd5ab into taichi-dev:master Nov 3, 2021
@k-ye k-ye mentioned this pull request Dec 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihong0618 yihong0618 yihong0618 left review comments

@k-ye k-ye k-ye left review comments

@strongoier strongoier strongoier left review comments

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@squarefk @k-ye @strongoier @ailzhang @yihong0618 @taichi-gardener