Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix the path in conda_env.yaml #2895

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

gaocegege
Copy link
Collaborator

@gaocegege gaocegege commented Sep 9, 2021

Related issue = null

When I follow the comment to create conda env, there's an error like this:

EnvironmentFileNotFound: 'taichi/conda/conda-env.yaml' file not found

This PR is to fix the typo in conda_env.yaml

Signed-off-by: cegao <cegao@tencent.com>
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@ailzhang ailzhang changed the title fix(conda): Fix the path in conda_env.yaml [Misc] Fix the path in conda_env.yaml Sep 9, 2021
@gaocegege
Copy link
Collaborator Author

Thanks for your help, should I re-push the commit to trigger a new presubmit CI build?

@ailzhang
Copy link
Contributor

ailzhang commented Sep 9, 2021

@gaocegege As long as other tests pass this is fine :D No need to push another commit for now ;)

@yuanming-hu
Copy link
Member

Btw, welcome to the Taichi developer community! @gaocegege :-)

@gaocegege
Copy link
Collaborator Author

Thanks for the awesome work.

This PR is just to get familiar with the contribution process. Glad to dive deeper into some of the system's features.

@ailzhang ailzhang merged commit 2e3107f into taichi-dev:master Sep 9, 2021
@gaocegege gaocegege deleted the typo branch September 9, 2021 05:54
This was referenced Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants