[opengl] Use element_size as alignment in root buffer. #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/8kYvJaLz4HBSQrmCXrya8ByhdUWt [Deployment for 94a0e17 canceled] |
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 94a0e17 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61eebb1a7dca520008dbad8f |
k-ye
reviewed
Jan 24, 2022
ailzhang
force-pushed
the
align_element_opengl
branch
from
b70b126
to
efd2432
Compare
Fixes taichi-dev#4089 Also deduplicated the `get_snode_base_address` between compilation and aot module builder. We can do it only once when calculating root buffer size. Note the logic of calculating root buffer size might be further simplified, but I'll leave that to a separate PR as this one mainly focus on enforcing the alignment.
ailzhang
force-pushed
the
align_element_opengl
branch
from
efd2432
to
94a0e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4089
Also deduplicated the
get_snode_base_addressbetween compilation andaot module builder. We can do it only once when calculating root buffer
size.
Related issue = #