[refactor] [ir] Remove load_if_ptr and move pointer dereferencing to frontend-to-IR passes #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/7B91tXiAHYKAe9T4sUvtHaSDPNYd [Deployment for 2682531 canceled] |
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 2682531 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f0fdaa0bf8870008ada8dc 😎 Browse the preview: https://deploy-preview-4104--docsite-preview.netlify.app |
strongoier
approved these changes
Jan 25, 2022
re-xyr
force-pushed
the
no_ptr_frontend
branch
from
f3bdb79
to
bec8cc9
Compare
Remember to do this :-) |
…frontend-to-IR passes
re-xyr
force-pushed
the
no_ptr_frontend
branch
from
bec8cc9
to
2682531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3982
Frontend IR is supposed to be a language higher level than ChiIR, but unnecessary details of pointer manipulation (i.e.
LoadExpressions) are still present. Although users won't be able to notice this in python, that was achieved by spreadingload_if_ptracross literally the whole frontend. What's worse, for any expressione,LoadExpression(e)has the same types ase(that is, value type = pointer type), making bugs extremely easy to sneak in.This PR removed
LoadExpressions andload_if_ptrso that pointers are not visible in frontend. Instead, pointer dereferencing is done at frontend-to-IR passes (Expr::flatten()andirpass::lower_ast()) wtih helper functionsflatten_lvalue()(gives pointers) andflatten_rvalue()(gives values).