Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Prevent modules in lang being wild imported and exposed #4140

Merged
merged 7 commits into from
Jan 26, 2022

Conversation

qiao-bo
Copy link
Contributor

@qiao-bo qiao-bo commented Jan 26, 2022

Related issue = #3782

This PR prevents the modules in lang/ being exposed such as 'kernel_arguments', 'kernel_impl', 'ops' etc, except ti.tape and ti.sort.

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/CFuaYmLyYp9p1SB1N9HjT8F8Hu5a
✅ Preview: https://taichi-git-fork-qiao-bo-api1-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 8f4bf15

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f10bff9f1ab30007ac6e78

@qiao-bo
Copy link
Contributor Author

qiao-bo commented Jan 26, 2022

/format

@qiao-bo
Copy link
Contributor Author

qiao-bo commented Jan 26, 2022

/format

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qiao-bo qiao-bo merged commit 36880b8 into taichi-dev:master Jan 26, 2022
@qiao-bo qiao-bo deleted the api_1 branch January 26, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants